Redesigned dpnp.modf function to be a part of ufunc and vm pybind11 extensions
#2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
changed the title
dpnp.modf as part of pybind11 extension ufuncdpnp.modf as part of ufunc extension
Collaborator
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_53 ran successfully. |
antonwolfy
changed the title
dpnp.modf as part of ufunc extension dpnp.modf function to be a part of ufunc and vm pybind11 extensions
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
…th two output arrays
…both frexp and modf functions
antonwolfy
force-pushed
the
impl-modf
branch
from
57e4b99 to
53cc8b5
Compare
vlad-perevezentsev
approved these changes
Nov 12, 2025
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
Good job, LGTM
Thank you @antonwolfy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates implementation of
dpnp.modfto move it from old legacy backend to be part ofufuncandvmextensions.Also
DPNPUnaryTwoOutputsFuncclass is extended with support of oneMKL VM functions.The tests for unary functions with 2 output arrays are separated to
dpnp/tests/test_unary_two_outputs_ufuncs.pyfile.And the legacy implementation of
dpnp.modfwas cleaned up.